feat(config)!: support regex in 'tag_pattern' configuration #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
📢 Thoughts on this report? Let us know!. |
woshilapin
force-pushed
the
feat/regex-tag_pattern
branch
3 times, most recently
from
0fababf to
19da127
Compare
BREAKING CHANGE: `tag_pattern` now takes a valid regular expression instead of a glob pattern resolves orhun#289
woshilapin
force-pushed
the
feat/regex-tag_pattern
branch
from
19da127 to
8fee4c0
Compare
orhun
changed the title
inglor
pushed a commit
to archlinux/aurweb
that referenced
this pull request
Dec 8, 2023
Changed with v1.4.0 See: orhun/git-cliff#318 Signed-off-by: moson <moson@archlinux.org>
zedseven
added a commit
to zedseven/breeze
that referenced
this pull request
Jan 17, 2024
…attern`. This is required due to orhun/git-cliff#318.
zedseven
added a commit
to zedseven/clog
that referenced
this pull request
Feb 7, 2024
…attern`. This is required due to orhun/git-cliff#318.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #289
Description
Change how the configuration works about
tag_pattern. It was only supporting glob patterns for matching (mostly due to the underlying support of such glob bygit2). Now, it should directly supportRegex.Motivation and Context
Closes #289.
How Has This Been Tested?
An existing test had to be modified after the change.
Another test has been added to test more explicitly the modification.
Types of Changes
I believe this is a breaking change, since all existing configurations may now break (if it's not parsable as a valid regular expression). I created the commit accordingly (conventional commit).
Checklist: